Return error when shutdown() fails #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also added tests in WebAssembly/wasi-testsuite#94; will update the PR with the new link to WASI testsuite once the WASI testsuite PR is merged. |
loganek
force-pushed
the
loganek/fix-socket-shutdown
branch
from
6c0b7a2
to
458a747
Compare
|
@wenyongh could you have a look please? Thanks a lot |
LGTM. Should I merge it now? |
loganek
force-pushed
the
loganek/fix-socket-shutdown
branch
from
458a747
to
b1e52db
Compare
loganek
changed the title
loganek
force-pushed
the
loganek/fix-socket-shutdown
branch
2 times, most recently
from
79b5c1d
to
1a4e123
Compare
loganek
force-pushed
the
loganek/fix-socket-shutdown
branch
from
1a4e123
to
d110c68
Compare
I've actually updated the PR to cover all platforms, not just POSIX; could you have another look, and if it's good, feel free to merge it. |
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Fix issue reported in bytecodealliance#2787.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2787