-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an export name check exception #2806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fix doesn't seem right.
if we want to support names including '\00', we should stop using strlen etc.
It seems both import name and export name need to face gaps between cstyle name and unicode name:
Definity, we need an extra field to store name's length and use binary operations to replace "<string.h>" operations when dealing with import names and export names. Need to do include modifications about:
It is requires by Spec. But, is it a good idea to support unicode string as import name and export name? A lot modification Vs. unusual benefit. We tend to put a limitation of import names and export names that only c-style names are allowed.
|
96e3b79
to
4d8f1b6
Compare
9af0f77
to
ee277b6
Compare
ee277b6
to
804405f
Compare
804405f
to
b887ce5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ealliance#2806) Leave it as a limitation when import/export name contains '\00' in wasm file. p.s. bytecodealliance#2789
No description provided.