Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spec test for classic/fast-interp in NuttX CI #2817

Merged
merged 25 commits into from
Nov 27, 2023

Conversation

no1wudi
Copy link
Collaborator

@no1wudi no1wudi commented Nov 23, 2023

@wenyongh
Copy link
Contributor

Seems that riscv-64 and aarch64 are not tested, will we enable them in the future?

@no1wudi no1wudi marked this pull request as draft November 24, 2023 02:24
@no1wudi no1wudi marked this pull request as ready for review November 24, 2023 02:26
@no1wudi
Copy link
Collaborator Author

no1wudi commented Nov 24, 2023

Seems that riscv-64 and aarch64 are not tested, will we enable them in the future?

I'll enable them soon ( include gc spec test).

tests/wamr-test-suites/test_wamr.sh Outdated Show resolved Hide resolved
tests/wamr-test-suites/test_wamr.sh Outdated Show resolved Hide resolved
@no1wudi
Copy link
Collaborator Author

no1wudi commented Nov 27, 2023

@wenyongh Spectest workflow is ready to cover more target by add board and target configuration now, but need further debug to pass all test on the target that commented out, e.g. https://github.com/no1wudi/wasm-micro-runtime/actions/runs/7000142793

Please review this change, if it's OK for you we can consider merge it first and then fix the error to enable all targets step by step.

@wenyongh
Copy link
Contributor

@wenyongh Spectest workflow is ready to cover more target by add board and target configuration now, but need further debug to pass all test on the target that commented out, e.g. https://github.com/no1wudi/wasm-micro-runtime/actions/runs/7000142793

Please review this change, if it's OK for you we can consider merge it first and then fix the error to enable all targets step by step.

@no1wudi I am OK for the changes, my concern is that the CIs run failed, could we disable the failed targets, merge the PR, and then enable them one by one?

@no1wudi
Copy link
Collaborator Author

no1wudi commented Nov 27, 2023

@no1wudi I am OK for the changes, my concern is that the CIs run failed

Of course I'll fix the failedCI first, we should not introduce new issue in current CI.

Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit d760869 into bytecodealliance:main Nov 27, 2023
383 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants