-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run spec test for classic/fast-interp in NuttX CI #2817
Conversation
Seems that riscv-64 and aarch64 are not tested, will we enable them in the future? |
I'll enable them soon ( include gc spec test). |
0d8c872
to
d9f57dc
Compare
e979e45
to
af8d56b
Compare
3b0fafd
to
4168ab1
Compare
48ac0ce
to
f85b247
Compare
@wenyongh Spectest workflow is ready to cover more target by add board and target configuration now, but need further debug to pass all test on the target that commented out, e.g. https://github.com/no1wudi/wasm-micro-runtime/actions/runs/7000142793 Please review this change, if it's OK for you we can consider merge it first and then fix the error to enable all targets step by step. |
@no1wudi I am OK for the changes, my concern is that the CIs run failed, could we disable the failed targets, merge the PR, and then enable them one by one? |
Of course I'll fix the failedCI first, we should not introduce new issue in current CI. |
spec-test-script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Notice: It will take a long time to run, up to 4 hour, see: https://github.com/no1wudi/wasm-micro-runtime/actions/runs/6966974742 and https://github.com/no1wudi/wasm-micro-runtime/actions/runs/6969744155