Fix memory size not updating #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagehu
force-pushed
the
yagehu/memory-grow
branch
from
10431a1
to
7f8c1e5
Compare
This commit fixes linear memory size not updating after growing.
yagehu
force-pushed
the
yagehu/memory-grow
branch
from
7f8c1e5
to
01c9514
Compare
eloparco
reviewed
Dec 11, 2023
| @@ -2149,7 +2149,11 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module, | |||
| #if !defined(OS_ENABLE_HW_BOUND_CHECK) \ | |||
| || WASM_CPU_SUPPORTS_UNALIGNED_ADDR_ACCESS == 0 \ | |||
| || WASM_ENABLE_BULK_MEMORY != 0 | |||
| #if WASM_ENABLE_THREAD_MGR == 0 | |||
There was a problem hiding this comment.
You may want to be consistent with what we do at the beginning of the function:
wasm-micro-runtime/core/iwasm/interpreter/wasm_interp_classic.c
Lines 1160 to 1164 in 4aee3cf
Also, similar changes need to be made for wasm_interp_fast.c. See #2834
There was a problem hiding this comment.
Thanks for the review. I just pushed another commit that makes the check consistent and applies the same fix to wasm_interp_fast.c.
wenyongh
approved these changes
Dec 12, 2023
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…liance#2898) This commit fixes linear memory size not updating after growing. This causes `memory.fill` to throw an exception after `memory.grow`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes linear memory size not updating after growing. This causes
memory.fillto throw an exception aftermemory.grow.