Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors with new release #3007

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

Zzzabiyaka
Copy link
Contributor

@Zzzabiyaka Zzzabiyaka commented Jan 12, 2024

Hi!

When our team started updating to wamr-1.3.1 release we encountered some errors during the build (for example, not initialised non-trivial class member __paddings.

This PR addresses those errors.

Please let me know if default initializer for __paddings should look differently

@loganek
Copy link
Collaborator

loganek commented Jan 12, 2024

Please let me know if default initializer for __paddings should look differently

This field is just for padding and it shouldn't be used for anything else, so any value assigned to it should be ok.

LGTM

@yamt
Copy link
Collaborator

yamt commented Jan 12, 2024

what compiler are you using?
what errors did you get?
is the DEPRECATED changes related to __paddings things? how?

@Zzzabiyaka
Copy link
Contributor Author

_padding and DEPRECATED are 2 different issues, generally we should avoid using defines with generic names (such as DEPRECATED)

@Zzzabiyaka
Copy link
Contributor Author

_paddings issue looked smth like

 error: missing initializer for member ‘wasm_val_t::__paddings’ [-Werror=missing-field-initializers]
   64 |     wasm_val_t res = {WASM_INIT_VAL};

@wenyongh wenyongh merged commit 63012f0 into bytecodealliance:main Jan 13, 2024
393 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…ecodealliance#3007)

Errors were reported when initializing wasm_val_t values with WASM_I32_VAL like macros.
```
 error: missing initializer for member ‘wasm_val_t::__paddings’ [-Werror=missing-field-initializers]
   64 |     wasm_val_t res = {WASM_INIT_VAL};
```
And rename DEPRECATED to WASM_API_DEPRECATED to avoid using defines with generic names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants