Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quick aot entry when GC is enabled #3015

Merged

Conversation

wenyongh
Copy link
Contributor

No description provided.

@no1wudi
Copy link
Collaborator

no1wudi commented Jan 17, 2024

Try this docker image for spec test on nuttx:
sha256:8c4e00b607d4d6d66ba8f51c4544819a616eac69d3a2ac669e2af2150e2eb0f9

@@ -34,13 +34,13 @@ jobs:
with:
os: "ubuntu-22.04"
arch: "ARM RISCV AArch64"
container_image: ghcr.io/no1wudi/nuttx/apache-nuttx-ci-linux:latest
container_image: ghcr.io/no1wudi/nuttx/apache-nuttx-ci-linux:8c4e00b607d4d6d66ba8f51c4544819a616eac69d3a2ac669e2af2150e2eb0f9
Copy link
Collaborator

@no1wudi no1wudi Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container_image: ghcr.io/no1wudi/nuttx/apache-nuttx-ci-linux:8c4e00b607d4d6d66ba8f51c4544819a616eac69d3a2ac669e2af2150e2eb0f9
container_image: ghcr.io/no1wudi/nuttx/apache-nuttx-ci-linux:@sha256:8c4e00b607d4d6d66ba8f51c4544819a616eac69d3a2ac669e2af2150e2eb0f9


spec_test_on_qemu:
runs-on: ubuntu-latest
needs: [build_llvm_libraries]
container:
image: ghcr.io/no1wudi/nuttx/apache-nuttx-ci-linux:latest
image: ghcr.io/no1wudi/nuttx/apache-nuttx-ci-linux:8c4e00b607d4d6d66ba8f51c4544819a616eac69d3a2ac669e2af2150e2eb0f9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: ghcr.io/no1wudi/nuttx/apache-nuttx-ci-linux:8c4e00b607d4d6d66ba8f51c4544819a616eac69d3a2ac669e2af2150e2eb0f9
image: ghcr.io/no1wudi/nuttx/apache-nuttx-ci-linux:@sha256:8c4e00b607d4d6d66ba8f51c4544819a616eac69d3a2ac669e2af2150e2eb0f9

@no1wudi
Copy link
Collaborator

no1wudi commented Jan 17, 2024

Now it seems that this is an occasional error caused by the test script, try to retrigger the workflow again?

@wenyongh
Copy link
Contributor Author

wenyongh commented Jan 17, 2024

Now it seems that this is an occasional error caused by the test script, try to retrigger the workflow again?

Failed to run test-guard-page-skip, not sure why:
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/7553863769/job/20565649590

============> run skip-stack-guard-page failed with a non-zero return code 101

==================== LAST LOG of skip-stack-guard-page ====================


Testing(exhaustion) test-guard-page-skip 300 = Exception: call stack exhausted

THE FINAL EXCEPTION IS argument of type 'NoneType' is not iterable
Compiling '/tmp/tmpyh1l4lk5.wasm' to '/tmp/tmp7gmej11x.aot'

@wenyongh
Copy link
Contributor Author

Now it seems that this is an occasional error caused by the test script, try to retrigger the workflow again?

Failed to run test-guard-page-skip, not sure why: https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/7553863769/job/20565649590

============> run skip-stack-guard-page failed with a non-zero return code 101

==================== LAST LOG of skip-stack-guard-page ====================


Testing(exhaustion) test-guard-page-skip 300 = Exception: call stack exhausted

THE FINAL EXCEPTION IS argument of type 'NoneType' is not iterable
Compiling '/tmp/tmpyh1l4lk5.wasm' to '/tmp/tmp7gmej11x.aot'```

Run again, this CI runs successfully, but riscv32 CI failed:
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/7553863769/job/20568614964

============> run unreachable failed with a non-zero return code 101

==================== LAST LOG of unreachable ====================

THE FINAL EXCEPTION IS Failed:
 Result 0 incorrect:
 expected: 'Exception: unreachable'
  got: 'Exception: native stack overflow'

@wenyongh
Copy link
Contributor Author

@no1wudi I found the quick-aot-entry was not applied for aot when hw bound check isn't enabled, and the CIs run success when I fixed that with 446f4dd

But it might mean that in the original tests, the failed CIs may use wasm_runtime_invoke_native instead of quick-aot-entry to run spec cases, I am not sure whether there are errors in handling riscv ABI in wasm_runtime_invoke_native:
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/7553863769/job/20568614964
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/7553863769/job/20565649590

@wenyongh wenyongh merged commit 4f0551a into bytecodealliance:dev/gc_refactor Jan 18, 2024
404 checks passed
@wenyongh wenyongh deleted the enable_gc_quick_aot_entry branch January 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants