Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuttx: use larger alignment for os_mmap and comment why #3017

Merged
merged 1 commit into from
Jan 16, 2024
Merged

nuttx: use larger alignment for os_mmap and comment why #3017

merged 1 commit into from
Jan 16, 2024

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Jan 15, 2024

No description provided.

@yamt yamt mentioned this pull request Jan 15, 2024
Open
@yamt
Copy link
Collaborator Author

yamt commented Jan 15, 2024

the ci failure looks unrelated to this PR.

Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
Download action repository 'actions/cache@v3' (SHA:e12d46a63a90f2fae62d114769bbf2a179198b5c)
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (api.github.com:443)
Warning: Back off 18.599 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (api.github.com:443)
Warning: Back off 22.26 seconds before retry.
Error: nodename nor servname provided, or not known (api.github.com:443)

@yamt yamt marked this pull request as ready for review January 15, 2024 15:12
@yamt
Copy link
Collaborator Author

yamt commented Jan 15, 2024

other platforms with malloc-based os_mmap might need similar changes too, depending on their target cpu arch.

@wenyongh wenyongh merged commit 685d55d into bytecodealliance:main Jan 16, 2024
395 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@yamt
nuttx: Use larger alignment for os_mmap and comment why (bytecodealli…
50b8831 
…ance#3017)

Other platforms with malloc-based os_mmap might need similar changes
too, depending on their target cpu arch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@no1wudi no1wudi no1wudi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yamt @no1wudi @wenyongh