wamr-compiler: Fix non-x86{_64} host builds #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midokura-xavi92
force-pushed
the
wamrc-fix-nonx86-builds
branch
from
0553ca7
to
9b184b9
Compare
wenyongh
reviewed
Jan 17, 2024
So far, the build system assumed sizeof (void *) == 8 as a host system running on a x86_64 architecture, x86 otherwise. However, this assumption is invalid for most other architectures out there, such as aarch64 or armv7l. Instead, this commit refers to the CMAKE_HOST_SYSTEM_PROCESSOR variable which, according to the documentation, typically refers to the output from "uname -m" for Unix-like systems.
WAMR_BUILD_TARGET values such as RISCV64 or RISCV32 were not listed by the comment, but were in fact consumed by the CMakeLists.txt at a later stage.
midokura-xavi92
force-pushed
the
wamrc-fix-nonx86-builds
branch
from
9b184b9
to
9a0045c
Compare
|
|
no1wudi
approved these changes
Jan 17, 2024
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
The build system assumed sizeof (void *) == 8 as a host system running on a x86_64 architecture, x86 otherwise. However, this assumption is invalid for most other architectures out there, such as aarch64 or armv7l. This PR refers to the CMAKE_HOST_SYSTEM_PROCESSOR variable which, according to the documentation, typically refers to the output from "uname -m" for Unix-like systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the build system assumed
sizeof (void *) == 8as a host system running on ax86_64architecture,x86otherwise. However, this assumption is invalid for most other architectures out there, such asaarch64orarmv7l.Instead, this commit refers to the
CMAKE_HOST_SYSTEM_PROCESSORvariable which, according to the documentation, typically refers to the output fromuname -mfor Unix-like systems.