Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance setting write gs base with cmake variable #3066

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

wenyongh
Copy link
Contributor

In linux x86-64, developer can use cmake variable to configure whether
to enable writing linear memory base address to x86 GS register or not:

  • cmake -DWAMR_DISABLE_WRITE_GS_BASE=1: disabled it
  • cmake -DWAMR_DISABLE_WRITE_GS_BASE=0: enabled it
  • cmake without -DWAMR_DISABLE_WRITE_GS_BASE=1/0:
    auto-detected by the compiler

@wenyongh wenyongh merged commit c8b5958 into bytecodealliance:main Jan 23, 2024
405 checks passed
@wenyongh wenyongh deleted the enhance_write_gs_base branch January 25, 2024 02:49
ThomasDevoogdt added a commit to ThomasDevoogdt/fluent-bit that referenced this pull request Apr 20, 2024
Main reason for the bump:

Enhance setting write gs base with cmake variable ([fluent#3066](bytecodealliance/wasm-micro-runtime#3066))
 --> fixes cross compilation on buildroot

Other news:
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.1
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.2

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt added a commit to ThomasDevoogdt/fluent-bit that referenced this pull request Apr 20, 2024
Main reason for the bump:

Enhance setting write gs base with cmake variable (bytecodealliance/wasm-micro-runtime#3066)
 --> fixes cross compilation on buildroot

Other news:
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.1
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.2

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt added a commit to ThomasDevoogdt/fluent-bit that referenced this pull request May 23, 2024
Main reason for the bump:

Enhance setting write gs base with cmake variable (bytecodealliance/wasm-micro-runtime#3066)
 --> fixes cross compilation on buildroot

Other news:
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.1
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.2

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
)

In linux x86-64, developer can use cmake variable to configure whether
to enable writing linear memory base address to x86 GS register or not:
- `cmake -DWAMR_DISABLE_WRITE_GS_BASE=1`: disabled it
- `cmake -DWAMR_DISABLE_WRITE_GS_BASE=0`: enabled it
- `cmake` without `-DWAMR_DISABLE_WRITE_GS_BASE=1/0`:
        auto-detected by the compiler
ThomasDevoogdt added a commit to ThomasDevoogdt/fluent-bit that referenced this pull request Jun 8, 2024
Main reason for the bump:

Enhance setting write gs base with cmake variable (bytecodealliance/wasm-micro-runtime#3066)
 --> fixes cross compilation on buildroot

Other news:
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.1
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.2

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt added a commit to ThomasDevoogdt/fluent-bit that referenced this pull request Jul 9, 2024
Main reason for the bump:

Enhance setting write gs base with cmake variable (bytecodealliance/wasm-micro-runtime#3066)
 --> fixes cross compilation on buildroot

Other news:
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.1
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.2

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant