Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a ubsan complaint "applying zero offset to null pointer" #3160

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Feb 14, 2024

No description provided.

@yamt
Copy link
Collaborator Author

yamt commented Feb 16, 2024

the test failure looks unrelated. but honestly speaking i don't know what it's testing.

@wenyongh
Copy link
Contributor

the test failure looks unrelated. but honestly speaking i don't know what it's testing.

The CI ran failed when testing wamr-ide:

    1) Rust formatters
  2 passing (50s)
  1 failing
  1) Inegration Tests
       Rust formatters:

      The Deque summary string looks different than expected
      + expected - actual

      -alloc::collections::vec_deque::VecDeque<int, alloc::alloc::Global> @ 0xfff1c
      + (5) VecDeque[1, 2, 3, 4, 5]
      
  	at Context.<anonymous> (out/test/suite/extension.test.js:159:27)
  	at Generator.next (<anonymous>)
  	at fulfilled (out/test/suite/extension.test.js:9:58)
  	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

It failed recently when PR was created, it should be related to the code below:
https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/test-tools/wamr-ide/VSCode-Extension/src/test/suite/extension.test.ts#L177-L178

Not sure whether it is caused by the version update of nodejs or vscode, maybe @xujuntwt95329 and @TianlongLiang can help look into it after vocation.

I think it should be a minor issue, let's merge the PRs if they are well reviewed and other CIs run well.

@wenyongh wenyongh merged commit b0c54c8 into bytecodealliance:main Feb 17, 2024
405 of 406 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…ealliance#3160)

Set a type's `result_ref_type_maps` only when `ref_type_map_count > 0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants