zephyr: implement Alloc_With_System_Allocator #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Feb 23, 2024
add zephyr libc malloc/realloc/free Signed-off-by: Maxim Kolchurin <maxim.kolchurin@gmail.com>
mkolchurin
force-pushed
the
zephyr_malloc
branch
from
e4b73e0
to
000a0b7
Compare
wenyongh
reviewed
Feb 26, 2024
| @@ -129,8 +129,10 @@ iwasm_main(void *arg1, void *arg2, void *arg3) | |||
| init_args.mem_alloc_type = Alloc_With_Pool; | |||
| init_args.mem_alloc_option.pool.heap_buf = global_heap_buf; | |||
| init_args.mem_alloc_option.pool.heap_size = sizeof(global_heap_buf); | |||
| #elif (CONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE != 0 || CONFIG_NEWLIB_LIBC) | |||
There was a problem hiding this comment.
Is it better to use
((defined(CONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE) && CONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE != 0) \
|| defined(CONFIG_NEWLIB_LIBC))`? Some compiler may report error when the macros are not defined.
Check whether macros are defined instead using them directly to avoid potential compilation warnings.
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Add zephyr libc malloc/realloc/free which were introduced since version 1.13.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add zephyr libc malloc/realloc/free witch introduced since version 1.13.0