Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor and bug fix #3227

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

TianlongLiang
Copy link
Contributor

@TianlongLiang TianlongLiang commented Mar 14, 2024

  • go binding: type error(Error building on ./build.sh for go binding #3220)
  • python binding: type annotation uses the union operator "|", which requires Python version >=3.10
  • merged unused field used_to_be_wasi_ctx in AOTModuleInstance into reserved area
  • added field DefPointer(korp_mutex *, memory_lock); in WASMMemoryInstance for future refactor

Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit de803b2 into bytecodealliance:main Mar 14, 2024
406 checks passed
@TianlongLiang TianlongLiang deleted the dev/small_refactor branch March 27, 2024 09:17
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…ngs (bytecodealliance#3227)

- Merge unused field `used_to_be_wasi_ctx` in `AOTModuleInstance` into `reserved` area
- Add field `memory_lock` in `WASMMemoryInstance` for future refactor
- Go binding: fix type error
    bytecodealliance#3220
- Python binding:
    type annotation uses the union operator "|", which requires Python version >=3.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants