append \0 to every name string in aot name section
#3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Mar 25, 2024
lum1n0us
force-pushed
the
fix/aot_name_section_trailing_0
branch
3 times, most recently
from
af251d6
to
d7b4b80
Compare
wenyongh
approved these changes
Mar 26, 2024
lum1n0us
force-pushed
the
fix/aot_name_section_trailing_0
branch
from
d7b4b80
to
28d2dba
Compare
Since strings in .name section in .wasm is not c-style, need to append a `\0` to strings in .name section in .aot when emitting.
lum1n0us
force-pushed
the
fix/aot_name_section_trailing_0
branch
from
28d2dba
to
e487f2a
Compare
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…e#3249) Since strings in .name section in .wasm is not c-style, need to append a `\0` to each string in .name section in AOT file when emitting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since strings in .name section in .wasm is not c-style, need to append a
\0to strings in .name section in .aot when emitting.