Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuttX: migrate NuttX CMake build for WAMR #3256

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

xuxin930
Copy link
Contributor

Add NuttX CMake build support for platforms

@wenyongh
Copy link
Contributor

@no1wudi Could you help have a look? Thanks a lot.

if(CONFIG_INTERPRETERS_WAMR_LIB_PTHREAD)
# include lib_pthread.cmake
set(WAMR_BUILD_LIB_PTHREAD 1)
endif()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing WAMR_BUILD_GC and WAMR_BUILD_STRINGREF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing WAMR_BUILD_GC and WAMR_BUILD_STRINGREF

I added WAMR_BUILD_GC in the latest patchset, but I can't seem to find where to set WAMR_BUILD_STRINGREF

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in build-scripts/config_common.cmake:348

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAMR_BUILD_STRINGREF

😁 thx for you help, i added it to the latest patchset

if(CONFIG_INTERPRETERS_WAMR_GC)
  set(WAMR_BUILD_GC 1)
  set(WAMR_BUILD_STRINGREF 1)
  set(WAMR_BUILD_REF_TYPES 1)
endif()

@xuxin930 xuxin930 force-pushed the nuttx-cmake branch 2 times, most recently from b0f1bdb to ca6046b Compare March 28, 2024 14:35
@xuxin930 xuxin930 marked this pull request as draft March 29, 2024 15:00
@xuxin930 xuxin930 marked this pull request as ready for review March 29, 2024 15:12
@no1wudi
Copy link
Collaborator

no1wudi commented Apr 1, 2024

@xuxin930 Please trigger CI again

@xuxin930 xuxin930 force-pushed the nuttx-cmake branch 2 times, most recently from 93f4584 to a89956f Compare April 1, 2024 02:28
@xuxin930
Copy link
Contributor Author

xuxin930 commented Apr 1, 2024

@xuxin930 Please trigger CI again

It seems that there is something wrong with the environment settings of the arm MacOs.

@wenyongh
Copy link
Contributor

wenyongh commented Apr 1, 2024

@xuxin930 Please trigger CI again

It seems that there is something wrong with the environment settings of the arm MacOs.

It is a little strange that macos CI ran failed for this PR:
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/8502961539/job/23289867170

Run /usr/bin/env python3 -m pip install -r requirements.txt
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try brew install
    xyz, where xyz is the package you are trying to
    install.

While other PR ran well:
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/8503551804/job/23289206815

@wenyongh
Copy link
Contributor

wenyongh commented Apr 1, 2024

@xuxin930 @no1wudi I submitted PR #3270 to fix the macos CI issue.

@no1wudi
Copy link
Collaborator

no1wudi commented Apr 1, 2024

@xuxin930 Please rebase the main branch to fix the macOS CI.

Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
@wenyongh wenyongh merged commit bad9a2a into bytecodealliance:main Apr 2, 2024
384 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Add NuttX CMake build support for platforms.

Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants