-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuttX: migrate NuttX CMake build for WAMR #3256
Conversation
@no1wudi Could you help have a look? Thanks a lot. |
if(CONFIG_INTERPRETERS_WAMR_LIB_PTHREAD) | ||
# include lib_pthread.cmake | ||
set(WAMR_BUILD_LIB_PTHREAD 1) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing WAMR_BUILD_GC and WAMR_BUILD_STRINGREF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing WAMR_BUILD_GC and WAMR_BUILD_STRINGREF
I added WAMR_BUILD_GC in the latest patchset, but I can't seem to find where to set WAMR_BUILD_STRINGREF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in build-scripts/config_common.cmake:348
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WAMR_BUILD_STRINGREF
😁 thx for you help, i added it to the latest patchset
if(CONFIG_INTERPRETERS_WAMR_GC)
set(WAMR_BUILD_GC 1)
set(WAMR_BUILD_STRINGREF 1)
set(WAMR_BUILD_REF_TYPES 1)
endif()
b0f1bdb
to
ca6046b
Compare
@xuxin930 Please trigger CI again |
93f4584
to
a89956f
Compare
It seems that there is something wrong with the environment settings of the arm MacOs. |
It is a little strange that macos CI ran failed for this PR: Run /usr/bin/env python3 -m pip install -r requirements.txt
error: externally-managed-environment
× This environment is externally managed
╰─> To install Python packages system-wide, try brew install
xyz, where xyz is the package you are trying to
install. While other PR ran well: |
@xuxin930 Please rebase the main branch to fix the macOS CI. |
Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
Add NuttX CMake build support for platforms. Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
Add NuttX CMake build support for platforms