-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wamr to esp-idf components registry. #3264
Add wamr to esp-idf components registry. #3264
Conversation
idf_component.yml
Outdated
@@ -0,0 +1,8 @@ | |||
version: "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must this file be put under the root directory? There are already many files under root dir now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is need to be under the root directory, but version can be WAMR version plus bugfix version, for example now WAMR version is 1.3.2, we can make this to be 1.3.2-x(x is bugfix version is needed).
@wenyongh Today we have a meeting about this, we would like to use release branch of WAMR, because we may use this in real product, so master branch is not good choice, so I plan to merge this into release/v1.3.x version. |
f5df650
to
f61cdf4
Compare
@donghengqaz here are some questions to make sure we are on the same page.
|
f61cdf4
to
db3b2ab
Compare
Hi @lum1n0us,
You are right, and I will add another PR for main, but it had better to be published when v2.0 is released, because all versions in the registry are released, you can see they have a version filed. At first we plan to publish version based on WAMR release branch, because some internal developers and customers need a stable version to start developing product software.
Yes, this is very well. I will continue to publish new version to registry, you can see WAMR version in registry as follows:
The |
@donghengqaz the CI runs failed since the wamr-ide CI issue isn't fixed yet (which is fixed in main branch), I submitted PR #3268 to fix the issues that were fixed in main branch, and will merge your PR after that PR is merged. And after that, we may try to create release 1.3.3. |
|
OK. In the main branch, which version in file |
db3b2ab
to
759835f
Compare
759835f
to
8c7f428
Compare
The next planned release version in main is 2.0.0, maybe you can use it in idf_component.yml? |
OK. |
This PR is for the main branch, but only the released branch will be pushed into Espressif component registry. See also similar fixes in branch release/1.3.x: bytecodealliance#3264 bytecodealliance#3288
This PR is for the main branch, but only the released branch will be pushed into Espressif component registry. See also similar fixes in branch release/1.3.x: bytecodealliance#3264 bytecodealliance#3288 Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
This PR is for the main branch, but only the released branch will be pushed into Espressif component registry. See also similar fixes in branch release/1.3.x: bytecodealliance#3264 bytecodealliance#3288
This PR is for the main branch, but only the released branch will be pushed into Espressif component registry. See also similar fixes in branch release/1.3.x: bytecodealliance#3264 bytecodealliance#3288 Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
Espressif has ESP-IDF component registry to manage external components, and developers can use this directly and easily.
I plan to add
wasm-micro-runtime
to this registry, but it seems that wasm-micro-runtime team will not plan to cost much resource to maintain ESP-IDF platform and its related things, so I discuss with some internal Espressif developers. We hope you approve to let us publish WAMR into this registry with specific version(not WAMR official version). If some patches need to add for ESP-IDF platform, I will raised PR here, and when this PR is merged, I publish new version to registry.If you want to register account in this registry, please add me into your namespace with necessary access permissions, otherwise we plan to use our own account to publish WAMR.