Add wasm_runtime_detect_native_stack_overflow_size #3355

yamt · 2024-04-25T06:35:21Z

Add a few API (per-host function override of native stack requirement #3325)

wasm_runtime_detect_native_stack_overflow_size
wasm_runtime_detect_native_stack_overflow

Adapt the runtime to use them
Adapt samples/native-stack-overflow to use them
Add a few missing overflow checks in the interpreters
build and run the sample on the CI

yamt · 2024-04-25T10:26:48Z

windows failure looks like #2776

macos failure looks unrelated:

-- Check for working C compiler: /usr/bin/cc
CMake Error at /usr/local/Cellar/cmake/3.29.2/share/cmake/Modules/CMakeTestCCompiler.cmake:67 (message):
  The C compiler

    "/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/Users/runner/work/wasm-micro-runtime/wasm-micro-runtime/product-mini/platforms/darwin/build/CMakeFiles/CMakeScratch/TryCompile-soOD6B'
    
    Run Build Command(s): /usr/local/Cellar/cmake/3.29.2/bin/cmake -E env VERBOSE=1 /usr/bin/make -f Makefile cmTC_bee20/fast
    sh: line 1:  6878 Killed: 9               /Applications/Xcode_14.2.app/Contents/Developer/usr/bin/xcodebuild -sdk '' -find make 2> /dev/null
    make: error: sh -c '/Applications/Xcode_14.2.app/Contents/Developer/usr/bin/xcodebuild -sdk '' -find make 2> /dev/null' failed with exit code 35072: (null) (errno=No such file or directory)
    xcode-select: Failed to locate 'make', requesting installation of command line developer tools.
    
    

  

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:6 (project)


-- Check for working C compiler: /usr/bin/cc - broken
-- Configuring incomplete, errors occurred!

wenyongh · 2024-04-25T12:01:48Z

windows failure looks like #2776

macos failure looks unrelated:

-- Check for working C compiler: /usr/bin/cc
CMake Error at /usr/local/Cellar/cmake/3.29.2/share/cmake/Modules/CMakeTestCCompiler.cmake:67 (message):
  The C compiler

    "/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/Users/runner/work/wasm-micro-runtime/wasm-micro-runtime/product-mini/platforms/darwin/build/CMakeFiles/CMakeScratch/TryCompile-soOD6B'
    
    Run Build Command(s): /usr/local/Cellar/cmake/3.29.2/bin/cmake -E env VERBOSE=1 /usr/bin/make -f Makefile cmTC_bee20/fast
    sh: line 1:  6878 Killed: 9               /Applications/Xcode_14.2.app/Contents/Developer/usr/bin/xcodebuild -sdk '' -find make 2> /dev/null
    make: error: sh -c '/Applications/Xcode_14.2.app/Contents/Developer/usr/bin/xcodebuild -sdk '' -find make 2> /dev/null' failed with exit code 35072: (null) (errno=No such file or directory)
    xcode-select: Failed to locate 'make', requesting installation of command line developer tools.
    
    

  

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:6 (project)


-- Check for working C compiler: /usr/bin/cc - broken
-- Configuring incomplete, errors occurred!

The two CIs were re-run and are OK now.

wenyongh

LGTM with minor issues

wenyongh · 2024-04-25T12:50:31Z

core/iwasm/include/wasm_export.h

+ * Otherwise, raise a "native stack overflow" trap and returns false.
+ *
+ * Note: please do not expect a very strict detection. it's a good idea
+ * to give some margins. wasm_runtime_detect_native_stack_overflow itslf


Had better itself

wenyongh · 2024-04-25T12:55:01Z

core/iwasm/include/wasm_export.h

+ * Ensure that the calling thread still has a reasonable amount of
+ * native stack (WASM_STACK_GUARD_SIZE bytes) available.
+ *
+ * If enough stack is left, returns true.


had better returns -> return?

wenyongh · 2024-04-25T12:55:23Z

core/iwasm/include/wasm_export.h

+ * native stack (WASM_STACK_GUARD_SIZE bytes) available.
+ *
+ * If enough stack is left, returns true.
+ * Otherwise, raise a "native stack overflow" trap and returns false.


had better returns -> return?

yamt · 2024-04-25T13:17:58Z

force pushed to resolve a conflict with #3358

core/iwasm/common/wasm_runtime_common.c

this changes the accounting by one small function call. i don't think it can cause real problems though.

…verflow replace homegrown check.

This allows each native function to require more native stack. cf. bytecodealliance#3325

…ions

To avoid: LLVM ERROR: Only small, tiny and large code models are allowed on AArch64

as i have no good way to debug right now. the failure seen on the CI: ``` ====== Interpreter test1 stack size | fail? | leak? | exception --------------------------------------------------------------------------- 0 - 24576 | failed | ok | Exception: native stack overflow ====== Interpreter WAMR_DISABLE_HW_BOUND_CHECK=1 test1 stack size | fail? | leak? | exception --------------------------------------------------------------------------- 0 - 3568 | failed | ok | Exception: native stack overflow 3568 - 24576 | failed | ok | Exception: wasm operand stack overflow ====== AOT test1 stack size | fail? | leak? | exception --------------------------------------------------------------------------- 0 - 24576 | failed | ok | Exception: native stack overflow ====== AOT WAMR_DISABLE_HW_BOUND_CHECK=1 test1 stack size | fail? | leak? | exception --------------------------------------------------------------------------- 0 - 4000 | failed | ok | Exception: native stack overflow 4000 - 24576 | ok | ok | ====== Interpreter test2 stack size | fail? | leak? | exception --------------------------------------------------------------------------- 0 - 24576 | failed | ok | Exception: native stack overflow ====== Interpreter WAMR_DISABLE_HW_BOUND_CHECK=1 test2 ./run.sh: line 12: 14708 Segmentation fault: 11 out/native-stack-overflow.WAMR_DISABLE_HW_BOUND_CHECK out/wasm-apps/testapp.wasm ${NAME} ```

fix an infinite loop in consume_stack1

yamt · 2024-04-26T07:01:47Z

rebased after #3366

…3355) - Add a few API (bytecodealliance#3325) ```c wasm_runtime_detect_native_stack_overflow_size wasm_runtime_detect_native_stack_overflow ``` - Adapt the runtime to use them - Adapt samples/native-stack-overflow to use them - Add a few missing overflow checks in the interpreters - Build and run the sample on the CI

…3355) - Add a few API (bytecodealliance#3325) ```c wasm_runtime_detect_native_stack_overflow_size wasm_runtime_detect_native_stack_overflow ``` - Adapt the runtime to use them - Adapt samples/native-stack-overflow to use them - Add a few missing overflow checks in the interpreters - Build and run the sample on the CI Signed-off-by: victoryang00 <victoryang00@ucsc.edu>

…3355) - Add a few API (bytecodealliance#3325) ```c wasm_runtime_detect_native_stack_overflow_size wasm_runtime_detect_native_stack_overflow ``` - Adapt the runtime to use them - Adapt samples/native-stack-overflow to use them - Add a few missing overflow checks in the interpreters - Build and run the sample on the CI

…3355) - Add a few API (bytecodealliance#3325) ```c wasm_runtime_detect_native_stack_overflow_size wasm_runtime_detect_native_stack_overflow ``` - Adapt the runtime to use them - Adapt samples/native-stack-overflow to use them - Add a few missing overflow checks in the interpreters - Build and run the sample on the CI Signed-off-by: victoryang00 <victoryang00@ucsc.edu>

yamt added the native stack overflow detection label Apr 25, 2024

yamt force-pushed the native-stack-overflow-wip2 branch from c2976a3 to dd6e020 Compare April 25, 2024 10:03

yamt marked this pull request as ready for review April 25, 2024 10:26

wenyongh reviewed Apr 25, 2024

View reviewed changes

yamt force-pushed the native-stack-overflow-wip2 branch from dd6e020 to e0eb25f Compare April 25, 2024 13:16

wenyongh reviewed Apr 26, 2024

View reviewed changes

core/iwasm/common/wasm_runtime_common.c Show resolved Hide resolved

wenyongh approved these changes Apr 26, 2024

View reviewed changes

yamt added 20 commits April 26, 2024 16:00

add wasm_runtime_detect_native_stack_overflow

df96828

consume wasm_runtime_detect_native_stack_overflow

ffa17f3

this changes the accounting by one small function call. i don't think it can cause real problems though.

export wasm_runtime_detect_native_stack_overflow

49d2a64

samples/native-stack-overflow: use wasm_runtime_detect_native_stack_o…

81e5d03

…verflow replace homegrown check.

Add wasm_runtime_detect_native_stack_overflow_size

0c95ad0

This allows each native function to require more native stack. cf. bytecodealliance#3325

interpreters: Check native stack overflow for recursive calls

2107dba

interpreters: Check native stack overflow before calling native funct…

32e5b5d

…ions

add a comment on wasm_runtime_detect_native_stack_overflow

5b22812

add a comment on wasm_runtime_detect_native_stack_overflow_size

b373c27

host_consume_stack: use wasm_runtime_detect_native_stack_overflow_size

9d5c3ac

samples/native-stack-overflow: reduce a margin

a8ca169

CI: build and run samples/native-stack-overflow

0397d4f

samples/native-stack-overflow: clang-format

725aac3

appease GCC -Wmaybe-uninitialized

a887eca

fix build with GCC

71d02fd

samples/native-stack-overflow: use size_level=0

74be598

To avoid: LLVM ERROR: Only small, tiny and large code models are allowed on AArch64

disable tail-call for gcc

6607b2f

fix an infinite loop in consume_stack1

minor comment fixes

f6b57ab

simplify

be17b3f

handle native_stack_boundary==NULL case

6196f1c

yamt force-pushed the native-stack-overflow-wip2 branch from e971376 to 6196f1c Compare April 26, 2024 07:00

wenyongh merged commit 410ee58 into bytecodealliance:main Apr 26, 2024
669 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wasm_runtime_detect_native_stack_overflow_size #3355

Add wasm_runtime_detect_native_stack_overflow_size #3355

yamt commented Apr 25, 2024 •

edited

yamt commented Apr 25, 2024

wenyongh commented Apr 25, 2024

wenyongh left a comment

wenyongh Apr 25, 2024

wenyongh Apr 25, 2024

wenyongh Apr 25, 2024

yamt commented Apr 25, 2024

yamt commented Apr 26, 2024

Add wasm_runtime_detect_native_stack_overflow_size #3355

Add wasm_runtime_detect_native_stack_overflow_size #3355

Conversation

yamt commented Apr 25, 2024 • edited

yamt commented Apr 25, 2024

wenyongh commented Apr 25, 2024

wenyongh left a comment

Choose a reason for hiding this comment

wenyongh Apr 25, 2024

Choose a reason for hiding this comment

wenyongh Apr 25, 2024

Choose a reason for hiding this comment

wenyongh Apr 25, 2024

Choose a reason for hiding this comment

yamt commented Apr 25, 2024

yamt commented Apr 26, 2024

yamt commented Apr 25, 2024 •

edited