Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loader handling if block without op else #3404

Merged
merged 3 commits into from
May 9, 2024

Conversation

wenyongh
Copy link
Contributor

@wenyongh wenyongh commented May 8, 2024

If there is no else branch for the if block, make a virtual else opcode for
easier checking and to copy the correct results to the block return address
in fast-interp mode.

Reported in issue #3386, #3387, #3388.

Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TianlongLiang
Copy link
Contributor

LGTM

@wenyongh wenyongh merged commit a6c0cb7 into bytecodealliance:main May 9, 2024
376 checks passed
@wenyongh wenyongh deleted the fix_loader_op_end branch May 9, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants