wasm loader: Fix pop invalid offset count when stack top is ANY #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
| @@ -10888,6 +10887,12 @@ wasm_loader_get_custom_section(WASMModule *module, const char *name, | |||
| } | |||
| #endif | |||
|
|
|||
| #if 0 | |||
| #define HANDLE_OPCODE(opcode) #opcode | |||
| DEFINE_GOTO_TABLE(const char *, op_mnemonics); | |||
There was a problem hiding this comment.
Is this mnemonics opcode table aimed to facilitate debugging in wasm_loader?
There was a problem hiding this comment.
Yes, in wasm_loader_prepare_bytecode, when traversing opcodes, we can print opcode name, e.g. printf("##%s\n", op_mnemonics[opcode]);.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wasm_loader_pop_frame_offset, when the stack is in polymorphic state
and the stack top operand is VALUE_TYPE_ANY, if we popping I64/F64
operand, we should pop one offset but not two offsets.
The issue was reported in #3513 and #3514.