Clarify license of the wast crate
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a mistake originating from 6ae3b27 where when the crate was originally relicensed from "MIT/Apache-2.0" to "Apache-2.0 WITH LLVM-exception" I forgot to delete the corresponding license files or update time. The `Cargo.toml` of `wast` says that it has the "Apache-2.0 WITH LLVM-exception" license but the license files themselves still look like "MIT/Apache-2.0". This clarifies the situation by deleting the extraneous files to inherit the repository's "Apache-2.0 WITH LLVM-exception" license.
Closed
fitzgen
approved these changes
Jan 26, 2021
abrown
approved these changes
Jan 26, 2021
pepyakin
approved these changes
Jan 26, 2021
pchickey
approved these changes
Jan 26, 2021
|
@alexcrichton I approve these changes. |
|
@alexcrichton, I am fine with this clarification. |
|
@alexcrichton I am fine with the license clarification as well. |
|
@alexcrichton I approve these changes. |
|
@alexcrichton I approve these changes :-). |
|
Ok thanks everyone! |
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Nov 16, 2022
* Split out an `Enum` type from the `Variant` type This was not 100% straightforward as the lowering of an enum wants to be `the_value as i32` in the Rust-to-wasm generator, but that's not working because sometimes `the_value` has type `&T` instead of `T` which can't be cast to `i32`. This means that lowerings in Rust are now always producing a `match` statement which should optimize to the same thing but won't be as easy on the eyes. Additionally a small change was made to the C code generator that `expected<_, _>` is now represented as a struct-of-union instead of special-cased to be an `enum`. The only reason it was special cased prior was that it was accidentally interpreted as an `enum` due to the `Variant::is_enum` check (which is now removed). * Move a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a mistake originating from 6ae3b27 where when the
crate was originally relicensed from "MIT/Apache-2.0" to "Apache-2.0
WITH LLVM-exception" I forgot to delete the corresponding license files
or update time. The
Cargo.tomlofwastsays that it has the"Apache-2.0 WITH LLVM-exception" license but the license files
themselves still look like "MIT/Apache-2.0". This clarifies the
situation by deleting the extraneous files to inherit the repository's
"Apache-2.0 WITH LLVM-exception" license.
To be extra-conservative here I'm going to ask for the sign-off of anyone who
has previously modified the
wastcrate. I've cc'd the authors below and ifyou are ok with this change it would be great if you could comment as such or
approve the PR.