Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license files in crates #270

Merged
merged 1 commit into from May 10, 2021
Merged

Conversation

olivierlemasle
Copy link
Contributor

This Pull Request adds the LICENSE files in published crates.

I'm currently packaging crates wat, wast and wasmparser for Fedora, and Fedora packages should have license files.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

A minor logistical question -- I'm not actually sure if the symlinks here will cause unforeseen issues on some platforms. Specifically it looks like git on Windows will just create a text file containing the path; I suppose that's kind-of OK, though it may be better to just copy the file. @alexcrichton opinions on this?

(Separately, as a Fedora user, thank you for packaging these, and let us know if we can help in any way with getting any of the other BA projects into Fedora's repositories!)

@olivierlemasle
Copy link
Contributor Author

A minor logistical question -- I'm not actually sure if the symlinks here will cause unforeseen issues on some platforms. Specifically it looks like git on Windows will just create a text file containing the path; I suppose that's kind-of OK, though it may be better to just copy the file.

I did not test on Windows, and I'm ok with copying the license file if you prefer.

FYI, wasm-smith already uses a symlink for license since its re-licensing in commit ed55b56.

Separately, as a Fedora user, thank you for packaging these, and let us know if we can help in any way with getting any of the other BA projects into Fedora's repositories!

Thanks! Actually, I plan to package wasmtime-go and all its dependencies, which includes wasmtime, wat, wast, cranelift and many BA crates...

@cfallin
Copy link
Member

cfallin commented May 10, 2021

FYI, wasm-smith already uses a symlink for license since its re-licensing in commit ed55b56.

Ah, that indeed answers my concern -- "we already do it and it works" is quite a good reason!

@cfallin cfallin merged commit 6263fa5 into bytecodealliance:main May 10, 2021
@olivierlemasle olivierlemasle deleted the licenses branch May 10, 2021 17:53
@alexcrichton
Copy link
Member

Ah yeah I haven't had any issues with this myself yet, but I haven't tested it rigorously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants