wasmparser: Implement missing WasmFeatures configs #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following Wasm proposals are now covered by the WasmFeatures type: - saturating_float_to_int - sign_extension - mutable_global All enabled by default.
Robbepop
changed the title
alexcrichton
approved these changes
Feb 15, 2022
Now makes use of the already existing entity type check.
|
@alexcrichton Thanks for your review. I applied all your review suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #481
The following Wasm proposals are now covered by the WasmFeatures type:
saturating_float_to_intsign_extensionmutable_globalAll those features are enabled by default to not break existing code that uses
WasmFeatures::deafult.The Wasm spec has verbose names for
sign_extensionand especiallysaturating_float_to_intwithsign-extension-opsandnontrapping-float-to-int-conversionsso I thought it is nicer to have shorter names in theWasmFeaturesstruct. If the maintainers of thewasmparsercrate don't like this I'd love to accept name proposals.Since there were no negative feature tests for all the other features (from what I saw) I didn't know if those tests are actually wanted. If those tests are wanted I can implement them as well for the new features.