Skip to content

Commit

Permalink
cranelift: don't enable trace-log feature by default (#6549) (#6553)
Browse files Browse the repository at this point in the history
In #5382 ("egraph support: rewrite to work in terms of CLIF data
structures"), we added the `trace-log` feature to the set of default
features for `cranelift-codegen`. I think this was an accident, probably
added while debugging and overlooked when cleaning up to merge.

So let's undo that change. Fixes #6548.
  • Loading branch information
jameysharp committed Jun 12, 2023
1 parent 859aab6 commit ad1fccf
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions RELEASES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
--------------------------------------------------------------------------------
## 9.0.4

Released 2023-06-12.

### Fixed

* Remove the `trace-log` feature from cranelift-codegen's default features, to
fix a performance regression when compiling large WebAssembly modules.
[#6553](https://github.com/bytecodealliance/wasmtime/pull/6553)

--------------------------------------------------------------------------------
## 9.0.3

Expand Down
2 changes: 1 addition & 1 deletion cranelift/codegen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ cranelift-codegen-meta = { path = "meta", version = "0.96.3" }
cranelift-isle = { path = "../isle/isle", version = "=0.96.3" }

[features]
default = ["std", "unwind", "trace-log"]
default = ["std", "unwind"]

# The "std" feature enables use of libstd. The "core" feature enables use
# of some minimal std-like replacement libraries. At least one of these two
Expand Down

0 comments on commit ad1fccf

Please sign in to comment.