-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winch: Assertion failure with saturating conversion instructions #8848
Comments
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Thanks for catching this one Alex. I'll take a look. |
saulecabrera
added a commit
to saulecabrera/wasmtime
that referenced
this issue
Jun 28, 2024
Fixes: bytecodealliance#8848 Similar to all the control instructions, any state must be explicitly saved before emitting the code for `br_if`. This commit ensures that live locals and registers are explicilty saved before emitting the code for `br_if`. Prior to this commit, live locals and registers were not saved every time causing incorrect behavior in cases where the calculation of the conditional argument didn't trigger a spill. This change introduces the explicit spill after calculating the branch condition argument to minimize memory traffic in case the conditional is already in a register.
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 28, 2024
Fixes: #8848 Similar to all the control instructions, any state must be explicitly saved before emitting the code for `br_if`. This commit ensures that live locals and registers are explicilty saved before emitting the code for `br_if`. Prior to this commit, live locals and registers were not saved every time causing incorrect behavior in cases where the calculation of the conditional argument didn't trigger a spill. This change introduces the explicit spill after calculating the branch condition argument to minimize memory traffic in case the conditional is already in a register.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given this input:
since the implementation of saturating conversion instructions in #7909 this has panicked
cc @saulecabrera
The text was updated successfully, but these errors were encountered: