Implement tables and call_indirect #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Aug 11, 2018
lib/environ/src/environ.rs
Outdated
|
|
||
| // For some reason table_addr only works with I64. | ||
| let callee_i64 = pos.ins().uextend(I64, callee); | ||
| let table_entry_addr = pos.ins().table_addr(I64, table, callee_i64, 0); |
There was a problem hiding this comment.
The current limitation is that it be the same type as a pointer, fwiw.
There was a problem hiding this comment.
Oh, didn't know about that.
Then I would probably go with pointer_type() and extend only if needed.
lib/environ/src/environ.rs
Outdated
| debug_assert_eq!(table_index, 0, "non-default tables not supported yet"); | ||
|
|
There was a problem hiding this comment.
We should leave the comment about signature checking for now.
There was a problem hiding this comment.
😨 oh yeah you're right! That was unintended.
pepyakin
changed the title
pepyakin
changed the title
pepyakin
force-pushed
the
tables-n-call-indirect
branch
from
53182c8
to
d9c070a
Compare
sunfishcode
reviewed
Aug 15, 2018
howjmay
pushed a commit
to howjmay/wasmtime
that referenced
this pull request
Jan 24, 2022
Binds functions added in bytecodealliance#1654 Closes bytecodealliance#5
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 12, 2023
Currently traps for the `*_CPUTIME_*` clocks and doesn't check for overflow on nanoseconds.
frank-emrich
pushed a commit
to frank-emrich/wasmtime
that referenced
this pull request
Sep 27, 2023
Merge with upstream
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #9
Consists of only de6b9f1 for the moment of writing