Implement wasm trap handlers. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds signal handlers based on SpiderMonkey's signal-handler code. The functionality for looking up the trap code and wasm bytecode offset isn't yet implemented, but this is a start. I considered rewriting this code in Rust, but decided against it for now as C++ allows us to talk to the relevant OS APIs more directly. Fixes bytecodealliance#15.
sunfishcode
force-pushed
the
signalhandlers
branch
from
ea13683
to
7d20071
Compare
|
This code is now functional on Linux at least. I haven't tested Mac or Windows yet, though the C++ code this is based on support these platforms, so if anyone tries these before I have a chance to, please report any problems! |
|
Merging now as this is laying more infrastructure to build on. |
kubkon
pushed a commit
to kubkon/wasmtime
that referenced
this pull request
Mar 11, 2020
…e#27) and delete the submodule that was providing the path dep
pchickey
pushed a commit
that referenced
this pull request
May 20, 2021
…spacing
wasmtime-wiggle: only generate one add_{module}_to_linker func
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 12, 2023
…ytecodealliance#27) Add an API to implement proc_exit with, and implement it.
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
…ytecodealliance#27) Add an API to implement proc_exit with, and implement it.
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Oct 17, 2023
Merge with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds signal handlers based on SpiderMonkey's signal-handler code.
The functionality for looking up the trap code and wasm bytecode offset
isn't yet implemented, but this is a start.
I considered rewriting this code in Rust, but decided against it for now
as C++ allows us to talk to the relevant OS APIs more directly.
Fixes #15.