Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: always spill i32 with i64 stores #2840

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Apr 14, 2021

Fixes #2839. See also the issue description and comments in this commits for
details of what the fix is about here.

cc @cfallin @alexcrichton

Fixes bytecodealliance#2839. See also the issue description and comments in this commits for
details of what the fix is about here.
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this fix!

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. labels Apr 14, 2021
@cfallin cfallin merged commit 337cc47 into bytecodealliance:main Apr 14, 2021
@bnjbvr bnjbvr deleted the fix-2839 branch April 14, 2021 17:16
@alexcrichton
Copy link
Member

Oh dear sorry for the breakage, but thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type-confusion when storing i32 into a stack slot
3 participants