Allow i128 amount operands on shift instructions in the x64 backend #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
cfallin
reviewed
May 10, 2021
There was a problem hiding this comment.
Thank you @afonso360 for this PR!
Overall looks great; just one thought on the tests below.
|
|
||
| function %ishl_amt_i128(i64, i64, i8) -> i64, i64 { | ||
| block0(v0: i64, v1: i64, v2: i8): | ||
| v3 = uextend.i128 v2 |
There was a problem hiding this comment.
Could we add some cases that test the masking as well? A simple way to do this might just be v3 = uextend.i64 v2 / v4 = iconcat v3, v3, i.e. extend to 64 bits then replicate the 64 bits into the low and high parts.
There was a problem hiding this comment.
Yes, I've updated the existing test cases so that they all do that
afonso360
force-pushed
the
x64-i128-shift-amt
branch
from
45563b0
to
e021995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2727.
We handle the i128 cases by just ignoring the upper half of the source.