-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the simd_conversions test for AArch64 #3082
Enable the simd_conversions test for AArch64 #3082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I don't have a ton of experience with arm64 assembly, so I've got what's perhaps a newbie question if you're ok entertaining me. According ot the documentation of scvtf
it says:
A floating-point exception can be generated by this instruction. Depending on the settings in FPCR, the exception results in either a flag being set in FPSR, or a synchronous exception being generated. Floating-point exception traps in the ARM Architecture Reference Manual ARMv8, for ARMv8-A architecture profile.
Unfortunately the link on the page is a dead link, but I'm curious if this is something we need to worry about in the codegen here? I think that because all i32 values fit into an f64 we shouldn't have to worry about exceptions being generated, right? (not sure if there are other issues though)
@alexcrichton The question is not a problem at all; I am afraid that you have not been reading the best documentation on the subject, though that is not your fault. The proper reference for individual instructions (other than the Arm Architecture Reference Manual or Arm ARM, as people tend to call it) can be found on Arm's developer Web site - just click the "Architectures" drop-down menu, then "CPU Architecture", followed by the drop-down menu "A-Profile" in the middle of the page, and finally, probably the most counter-intuitive step, "Exploration tools" (or just use this direct link). This page links both to HTML and to XML renditions of the instruction descriptions (and the system register descriptions like the BTW the |
Ah ok that all definitely makes sense, thanks for the background info! In that case this definitely seems ok to me! |
3aa6109
to
03f9f33
Compare
Copyright (c) 2021, Arm Limited.
03f9f33
to
4a2fdf4
Compare
No description provided.