Enable the SIMD proposal by default #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates Wasmtime to enable the SIMD proposal for WebAssembly by default. Support has been implemented for quite some time and recently fuzzing has been running for multiple weeks without incident, so it seems like it might be time to go ahead and enable this!
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Awesome! I'm very excited to finally have this available.
Huge props to @jlb6740 @abrown @akirilov-arm @sparker-arm in particular for getting the implementations on x86-64 and aarch64 to production-quality!
Don't store a `bool` but rather an `Option<bool>` so we can inherit the defaults from Wasmtime rather than having to keep the defaults in-sync.
PiotrSikora
added a commit
to PiotrSikora/wasmtime
that referenced
this pull request
Apr 19, 2022
Missed in bytecodealliance#3601. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
abrown
pushed a commit
that referenced
this pull request
Apr 19, 2022
Missed in #3601. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates Wasmtime to enable the SIMD proposal for WebAssembly
by default. Support has been implemented for quite some time and
recently fuzzing has been running for multiple weeks without incident,
so it seems like it might be time to go ahead and enable this!