Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift: Port ushr SIMD lowerings to ISLE on x64 #3688

Merged
merged 1 commit into from
Jan 13, 2022
Merged

cranelift: Port ushr SIMD lowerings to ISLE on x64 #3688

merged 1 commit into from
Jan 13, 2022

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 13, 2022

No description provided.

@fitzgen fitzgen requested a review from cfallin January 13, 2022 21:02
@fitzgen fitzgen force-pushed the ushr-simd-isle branch 2 times, most recently from 1cf4489 to ed3006a Compare January 13, 2022 21:04
cfallin
cfallin approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Much clearer to read with all the cases split out :-)

cranelift/codegen/src/isa/x64/lower.isle Outdated Show resolved Hide resolved
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen isle Related to the ISLE domain-specific language labels Jan 13, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@fitzgen
Copy link
Member Author

fitzgen commented Jan 13, 2022

Hm it looks like the fib-debug example is crashing with this patch, but only on windows.

@alexcrichton
Copy link
Member

Oh that looks like a Rust 1.58.0 thing which was just released most likely, probably unrelated to this PR

@fitzgen fitzgen merged commit 7d943f6 into bytecodealliance:main Jan 13, 2022
@fitzgen fitzgen deleted the ushr-simd-isle branch January 13, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fitzgen @alexcrichton @cfallin