x64: Migrate fcvt_from_sint and fcvt_low_from_sint to ISLE #4650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
approved these changes
Aug 9, 2022
| @@ -1527,6 +1527,7 @@ pub(crate) fn emit( | |||
| SseOpcode::Cvtdq2pd => (LegacyPrefixes::_F3, 0x0FE6, 2), | |||
| SseOpcode::Cvtpd2ps => (LegacyPrefixes::_66, 0x0F5A, 2), | |||
| SseOpcode::Cvtps2pd => (LegacyPrefixes::None, 0x0F5A, 2), | |||
| SseOpcode::Cvtdq2ps => (LegacyPrefixes::None, 0x0F5B, 2), | |||
There was a problem hiding this comment.
In addition to adding it here, can we remove it from here and make sure we switch over any uses of that (tweaking any handwritten uses of it in-place is fine for now)? Since the opcode has unary (one src, one dst) semantics it should only appear here, not elsewhere.
I'm also slightly suspect of the two cvt* opcodes above that one in XmmRmR too, and we should see if they should be moved over too, while we're at it...
elliottt
force-pushed
the
trevor/x64-fcvt
branch
from
ee99a41
to
cc0b69f
Compare
elliottt
force-pushed
the
trevor/x64-fcvt
branch
from
cc0b69f
to
0d9a272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
fcvt_from_sintandfcvt_low_from_sintto ISLE. Also support theCvtdq2psopcode when emittingXmmUnaryRmRinstructions.