x64: Lower stack_addr, udiv, sdiv, urem, srem, umulhi, smulhi in ISLE #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
elliottt
changed the title
cfallin
approved these changes
Aug 22, 2022
elliottt
force-pushed
the
trevor/x64-stack-addr
branch
from
47195c4
to
768e6ae
Compare
elliottt
force-pushed
the
trevor/x64-stack-addr
branch
from
d204f23
to
02ae8ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower
stack_addr,udiv,sdiv,urem,srem,umulhi, andsmulhiin ISLE.For
udiv,sdiv,urem, andsremI opted to move the original lowering into an extern constructor, as the interactions with rax and rdx for thedivinstruction didn't seem meaningful to implement in ISLE. However, I'm happy to revisit this choice and move more of the embedding into ISLE.