Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector bitcast support (AArch64 & Interpreter) #4820

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

dheaton-arm
Copy link
Contributor

Implemented support for bitcast on vector values for AArch64 and the
interpreter.

Also corrected the verifier to ensure that the size, in bits, of the input and
output types match for a bitcast, per the docs.

Copyright (c) 2022 Arm Limited

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:meta Everything related to the meta-language. labels Aug 30, 2022
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One possible simplification (removing the mov instruction entirely) but otherwise LGTM.

cranelift/codegen/src/isa/aarch64/lower.isle Outdated Show resolved Hide resolved
Implemented support for `bitcast` on vector values for AArch64 and the
interpreter.

Also corrected the verifier to ensure that the size, in bits, of the input and
output types match for a `bitcast`, per the docs.

Copyright (c) 2022 Arm Limited
Copyright (c) 2022 Arm Limited
@cfallin cfallin merged commit e786bda into bytecodealliance:main Sep 21, 2022
@dheaton-arm dheaton-arm deleted the isle-bitcasts branch September 22, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants