Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the aegraph (acyclic e-graph) implementation crate. #4909

Merged
merged 6 commits into from Sep 22, 2022

Conversation

cfallin
Copy link
Member

@cfallin cfallin commented Sep 14, 2022

This PR introduces the implementation of the aegraph data structure itself, as a new crate (cranelift-egraph).

This does not include any of the Cranelift-specific use of the aegraph (language/node definitions, egraph building, and lowering out of the egraph), nor any of the rule-rewriting on the egraph. That will come in subsequent PRs.

Stacks on top of #4908.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language labels Sep 14, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a bunch of comments, some of which are me just trying to figure stuff out and aren't necessarily actionable requests for code changes.

cranelift/egraph/src/ctxhash.rs Outdated Show resolved Hide resolved
cranelift/egraph/src/egraph.rs Outdated Show resolved Hide resolved
cranelift/egraph/src/egraph.rs Outdated Show resolved Hide resolved
cranelift/egraph/src/lib.rs Outdated Show resolved Hide resolved
cranelift/egraph/src/unionfind.rs Outdated Show resolved Hide resolved
cranelift/entity/src/list.rs Outdated Show resolved Hide resolved
cranelift/entity/src/list.rs Outdated Show resolved Hide resolved
cranelift/egraph/src/egraph.rs Outdated Show resolved Hide resolved
@cfallin
Copy link
Member Author

cfallin commented Sep 19, 2022

Rebased on top of latest #4908 and addressed feedback -- thanks! Will rebase on main and merge once #4908 merges.

@cfallin
Copy link
Member Author

cfallin commented Sep 21, 2022

Rebased now that #4908 has landed.

@cfallin cfallin enabled auto-merge (squash) September 21, 2022 23:43
@cfallin cfallin merged commit 89abd80 into bytecodealliance:main Sep 22, 2022
@cfallin cfallin deleted the aegraph-crate branch September 22, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants