Port flag-based ops to ISLE (AArch64) #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
Ported the existing implementations of the following opcodes for AArch64 to ISLE: - `Trueif` - `Trueff` - `Trapif` - `Trapff` - `Select` - `Selectif` - `SelectifSpectreGuard` Copyright (c) 2022 Arm Limited
dheaton-arm
force-pushed
the
isle-flags
branch
from
9bcce89
to
165e018
Compare
cfallin
approved these changes
Sep 22, 2022
| @@ -17,6 +17,7 @@ block0(v0: i64, v1: i64): | |||
| } | |||
|
|
|||
| ; block0: | |||
| ; adds x3, x0, x1 | |||
There was a problem hiding this comment.
Wow, I'm surprised the test was missing this before -- that was a clear miscompilation that I guess we never saw only because we always used the result of iadd_ifcout directly as well. In any case, this PR fixes the issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported the existing implementations of the following opcodes for AArch64 to ISLE:
TrueifTrueffTrapifTrapffSelectSelectifSelectifSpectreGuardAlso fixed the implementation of
true{if,ff}for the interpreter.Copyright (c) 2022 Arm Limited