Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AArch64] Fix incorrect regalloc constraints for atomic_cas #4959

Merged
merged 2 commits into from
Sep 26, 2022
Merged

[AArch64] Fix incorrect regalloc constraints for atomic_cas #4959

merged 2 commits into from
Sep 26, 2022

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Sep 26, 2022

This fixes a regression in Cranelift 0.88.0 that causes cg_clif's test suite to fail on AArch64.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels Sep 26, 2022
@bjorn3
Copy link
Contributor Author

bjorn3 commented Sep 26, 2022

The first commit can be directly applied against the release-1.0.0 branch. The commit after that blesses the test for the current main branch.

cfallin
cfallin approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the debugging effort here! This will make it for 2.0 for sure and I'll see about a patch release for 1.0 as well.

@cfallin cfallin enabled auto-merge (squash) September 26, 2022 16:04
@cfallin cfallin merged commit af226d3 into bytecodealliance:main Sep 26, 2022
@bjorn3 bjorn3 deleted the fix_aarch64_atomic_cas branch September 26, 2022 16:06
cfallin pushed a commit to cfallin/wasmtime that referenced this pull request Sep 26, 2022
@bjorn3 @cfallin
[AArch64] Fix incorrect regalloc constraints for atomic_cas (bytecode…
4c0d088 
…alliance#4959)

* [AArch64] Fix incorrect regalloc constraints for atomic_cas

* Update test for latest Cranelift changes
@cfallin cfallin mentioned this pull request Sep 26, 2022
Merged
cfallin added a commit that referenced this pull request Sep 26, 2022
@cfallin @bjorn3
Cherry-pick #4959 (aarch64 atomic_cas fix) to 1.0.0 release branch. (#…
bd2017a 
…4960)

* [AArch64] Fix incorrect regalloc constraints for atomic_cas (#4959)

* [AArch64] Fix incorrect regalloc constraints for atomic_cas

* Update test for latest Cranelift changes

* Update precise-output test for 1.0.0 regalloc.

Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjorn3 @cfallin