Move the wasmtime crate directories form lib/* to wasmtime-*. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good on principle (AppVeyor CI is broken, but that might be unrelated), thanks! |
This follows a similar change to Cranelift made here: bytecodealliance/cranelift#660
sunfishcode
force-pushed
the
package-dirs
branch
from
9c1f79f
to
722946c
Compare
|
Thanks! |
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 12, 2023
Use the dedicated `wasi-stderr` API for stderr, instead of `wasi-logging`. Fixes bytecodealliance#57.
dhil
referenced
this pull request
in wasmfx/wasmfxtime
Aug 31, 2023
This PR implements naive effect forwarding: When generating code for `resume`, we ensure that when asked to handle an effect not considered by the `resume` instruction under consideration, we simply `suspend` and let our own parent handle the unknown effect. Once resuming from that we use a back edge to the code that invokes `resume` on the current fiber (i.e., after moving up in the handler chain to find a handler, we move down in the chain back to where the original `suspend` of the unknown effect happened). Payloads are handled as follows: 1. When moving "up", we don't need to consider payloads: They are stored in the "payload buffer" of the `VMContext` and left untouched while moving upwards in the handler chain until the right handler is found and accesses the data. 2. When moving down, we need to deal with the "tag return payloads" that were provided via `resume` or `cont.bind` further up in the chain. These payloads are stored in continuation objects directly. Before resuming into our own child, we thus swap the payload pointers of the current continuation object and the child.
frank-emrich
pushed a commit
to frank-emrich/wasmtime
that referenced
this pull request
Nov 22, 2023
Merge with upstream
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows a similar change to Cranelift made here:
bytecodealliance/cranelift#660