-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove iadd_cout
and isub_bout
#6198
Conversation
Can unsigned_add_overflow_condition now be removed from TargetIsa? |
I would think that there is no reasonable use-case anymore since I don't see a way to get access to any flag for an add directly and with compares it does not make a lot of sense. |
Good catch! It looks like the only real callers of So yeah, I'd say let's delete that from both But I'd prefer to do that deletion in a separate PR. It shouldn't overlap with this one I think, so we can merge them in any order. Meanwhile, this PR looks like exactly the deletions I'd expect for removing these two instructions, so it's probably in good shape. I just want to ask, are the deleted tests and lowering rules all covered by equivalents for the new instructions? I didn't look closely at #5784. Also I want to double-check with @cfallin that there are no concerns about dropping |
The lowering rules are covered, |
I think it's fine to remove them now, given that we aren't losing any functionality, and the migration for any users we don't know about should be simple. The only other major user I'd be concerned about w.r.t. compatibility is cg_clif, and @bjorn3 is here aware of this PR already, so it seems we're fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's do this then!
Followup to #5784.
This removes the
iadd_cout
andisub_bout
instructions which can be replaced with{u,s}{add,sub}_overflow
directly.Searching for 'iadd_cout', 'isub_bout', 'IaddCout' and 'IsubBout' does not find anything anymore so I hope I deleted everything.