Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new c-api functions for configuring relaxed SIMD #6292

Merged

Conversation

martindevans
Copy link
Contributor

This allows the new relaxed SIMD features (introduced in #5892) to be configured through the C API:

Added:

  • wasmtime_config_wasm_relaxed_simd_set(bool)
  • wasmtime_config_wasm_relaxed_simd_deterministic_set(bool)

 - wasmtime_config_wasm_relaxed_simd_set(bool)
 - wasmtime_config_wasm_relaxed_simd_deterministic_set(bool)
@martindevans martindevans requested a review from a team as a code owner April 27, 2023 15:04
@martindevans martindevans requested review from pchickey and removed request for a team April 27, 2023 15:04
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also add C header API definitions for these new functions?

crates/wasmtime/src/config.rs Outdated Show resolved Hide resolved
@alexcrichton alexcrichton removed the request for review from pchickey April 27, 2023 15:43
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. wasmtime:config Issues related to the configuration of Wasmtime labels Apr 27, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:c-api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api, wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@martindevans
Copy link
Contributor Author

I don't think the suggestions by the github-actions bot apply here, since I'm just exposing a config option that already existed?

@alexcrichton alexcrichton added this pull request to the merge queue Apr 27, 2023
Merged via the queue into bytecodealliance:main with commit 5cce054 Apr 27, 2023
17 checks passed
@martindevans martindevans deleted the wasm_relaxed_simd_capi branch April 27, 2023 22:05
eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Apr 28, 2023
…iance#6292)

* Exposes new c-api functions for configuring relaxed SIMD:

 - wasmtime_config_wasm_relaxed_simd_set(bool)
 - wasmtime_config_wasm_relaxed_simd_deterministic_set(bool)

* Applied rustfmt suggestion

* Added header file entries for new calls

* Fixed link to `relaxed simd proposal`
@martindevans martindevans changed the title Exposes new c-api functions for configuring relaxed SIMD Expose new c-api functions for configuring relaxed SIMD May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants