Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Clone for wasmtime::component::Linker #7032

Merged

Conversation

acfoltzer
Copy link
Collaborator

The core Wasm Linker type is clonable, and the component linker needs to be used in similar settings where clonability is important.

@acfoltzer acfoltzer requested a review from a team as a code owner September 14, 2023 00:47
@acfoltzer acfoltzer self-assigned this Sep 14, 2023
@acfoltzer acfoltzer requested review from fitzgen and removed request for a team September 14, 2023 00:47
@acfoltzer acfoltzer marked this pull request as draft September 14, 2023 00:49
@acfoltzer
Copy link
Collaborator Author

D'oh, I immediately realized why there's a custom impl for the other Linker...

The core Wasm `Linker` type is clone, and the component linker needs to be used in similar settings
where clonability is important.
@acfoltzer acfoltzer marked this pull request as ready for review September 14, 2023 00:53
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Sep 14, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton alexcrichton added this pull request to the merge queue Sep 14, 2023
@alexcrichton
Copy link
Member

Thanks!

Merged via the queue into bytecodealliance:main with commit c4f261a Sep 14, 2023
18 checks passed
eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Sep 15, 2023
The core Wasm `Linker` type is clone, and the component linker needs to be used in similar settings
where clonability is important.
eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Sep 22, 2023
The core Wasm `Linker` type is clone, and the component linker needs to be used in similar settings
where clonability is important.
@acfoltzer acfoltzer deleted the component-linker-impl-clone branch September 25, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants