Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-api: expose memory_init_cow #7227

Merged
merged 2 commits into from Oct 12, 2023
Merged

c-api: expose memory_init_cow #7227

merged 2 commits into from Oct 12, 2023

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Oct 12, 2023

The main motivation for exposing this is if you're using a custom host allocator then you can't use these, so you might as well not generate them in the first place.

@rockwotj rockwotj requested a review from a team as a code owner October 12, 2023 16:44
@rockwotj rockwotj requested review from pchickey and removed request for a team October 12, 2023 16:44
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
I really wish these were autogenerated :/

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen added this pull request to the merge queue Oct 12, 2023
Merged via the queue into bytecodealliance:main with commit f534373 Oct 12, 2023
18 checks passed
@rockwotj rockwotj deleted the cow branch October 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants