Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCC: initial end-to-end integration with Wasmtime's static memories. #7274

Merged
merged 8 commits into from Oct 18, 2023

Conversation

cfallin
Copy link
Member

@cfallin cfallin commented Oct 17, 2023

This PR wires up end-to-end support for validating the compilation of accesses to static memories in Wasmtime. It creates "memory types" for the vmcontext struct and the memories it points to, and it adds PCC annotations to the relevant memory pointers. On aarch64 (where instruction semantics for PCC are implemented), this validates a simple i32.load function body with default memory configuration.

Note that facts are not yet propagated through egraph rewrites, so optimization has to be disabled for this to work; that support will come next.

Co-authored-by: Nick Fitzgerald fitzgen@gmail.com

@cfallin cfallin requested a review from fitzgen October 17, 2023 22:00
@cfallin cfallin requested review from a team as code owners October 17, 2023 22:00
cfallin and others added 5 commits October 17, 2023 15:00
…n yet.

Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:wasm labels Oct 17, 2023
cranelift/codegen/src/legalizer/globalvalue.rs Outdated Show resolved Hide resolved
cranelift/filetests/filetests/pcc/succeed/gv_fact.clif Outdated Show resolved Hide resolved
cranelift/wasm/src/code_translator/bounds_checks.rs Outdated Show resolved Hide resolved
cranelift/wasm/src/code_translator/bounds_checks.rs Outdated Show resolved Hide resolved
crates/cranelift/src/func_environ.rs Outdated Show resolved Hide resolved
@cfallin
Copy link
Member Author

cfallin commented Oct 17, 2023

Just a heads-up that the last commit has a few blessed expected-output changes on the Wasm memory access tests, because we had removed the special case vmctx GV lowering (so there are a few more aliases now). No functional change so I think it should be fine...

@github-actions github-actions bot added cranelift:meta Everything related to the meta-language. wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Oct 17, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:meta", "cranelift:wasm", "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@cfallin cfallin added this pull request to the merge queue Oct 17, 2023
Merged via the queue into bytecodealliance:main with commit 8e00cc2 Oct 18, 2023
18 checks passed
@cfallin cfallin deleted the pcc-wasm branch October 18, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:meta Everything related to the meta-language. cranelift:wasm cranelift Issues related to the Cranelift code generator wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants