wasi-http: Make all setters fallible #7451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
requested review from
alexcrichton and
pchickey
and removed request for
a team
elliottt
force-pushed
the
trevor/validation-error-type
branch
2 times, most recently
from
885bc56
to
38ed925
Compare
elliottt
force-pushed
the
trevor/validation-error-type
branch
2 times, most recently
from
a8dbf63
to
8c6a3e6
Compare
pchickey
reviewed
Nov 3, 2023
elliottt
force-pushed
the
trevor/validation-error-type
branch
from
4ee1db9
to
8b31ac3
Compare
pchickey
approved these changes
Nov 3, 2023
elliottt
force-pushed
the
trevor/validation-error-type
branch
from
8b31ac3
to
ae3a764
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
elliottt
force-pushed
the
trevor/validation-error-type
branch
from
ae3a764
to
7b42023
Compare
elliottt
force-pushed
the
trevor/validation-error-type
branch
from
7b42023
to
ab72ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
header-errorvariant tovalidation-error, and use that variant as the error value for all setters ofoutbound-requestandoutbound-response. This ensures that we have the opportunity to validate outbound request and response values before they're given to their respective handlers.Validation for uri components is done by using
http:uri::Builderwith only that value, ensuring that we don't raise an error. Validation for method and scheme is only done for theOthercases, and is accomplished by using the fallible parsers for each type from thehttpcrate.