Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-api: support disabling mach ports use on macos #7595

Merged

Conversation

casimiro
Copy link
Contributor

This PR proposes exposing macos_use_mach_ports engine configuration in the c-api.

As discussed here host applications that employ fork strategies might benefit from disabling macos_use_mach_ports when running on macOS.

@casimiro casimiro requested a review from a team as a code owner November 28, 2023 17:03
@casimiro casimiro requested review from pchickey and removed request for a team November 28, 2023 17:03
Copy link
Collaborator

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Nov 28, 2023
@github-actions github-actions bot added the wasmtime:c-api Issues pertaining to the C API. label Nov 28, 2023
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Merged via the queue into bytecodealliance:main with commit 1c7a07b Nov 28, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants