Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi-http: Make the host header forbidden #7905

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

elliottt
Copy link
Member

@elliottt elliottt commented Feb 9, 2024

As the host header is required for correctness, don't allow the guest to manipulate it directly, instead allowing them to set it via the authority field on a request.

@elliottt elliottt marked this pull request as ready for review February 9, 2024 21:42
@elliottt elliottt requested a review from a team as a code owner February 9, 2024 21:42
@elliottt elliottt requested review from alexcrichton and removed request for a team February 9, 2024 21:42
@elliottt elliottt added this pull request to the merge queue Feb 9, 2024
Merged via the queue into bytecodealliance:main with commit d6c31ac Feb 9, 2024
19 checks passed
@elliottt elliottt deleted the trevor/forbid-host-header branch February 9, 2024 22:47
rvolosatovs added a commit to rvolosatovs/wasmCloud that referenced this pull request Mar 25, 2024
Since bytecodealliance/wasmtime#7905, `host`
header in incoming requests is not available to guests

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs added a commit to rvolosatovs/wasmCloud that referenced this pull request Mar 25, 2024
Since bytecodealliance/wasmtime#7905, `host`
header in incoming requests is not available to guests

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs added a commit to wasmCloud/wasmCloud that referenced this pull request Mar 25, 2024
Since bytecodealliance/wasmtime#7905, `host`
header in incoming requests is not available to guests

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants