wasi-http: Make the host header forbidden #7905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/forbid-host-header
branch
from
fb01ae2
to
f281f15
Compare
alexcrichton
approved these changes
Feb 9, 2024
rvolosatovs
added a commit
to rvolosatovs/wasmCloud
that referenced
this pull request
Mar 25, 2024
Since bytecodealliance/wasmtime#7905, `host` header in incoming requests is not available to guests Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
added a commit
to rvolosatovs/wasmCloud
that referenced
this pull request
Mar 25, 2024
Since bytecodealliance/wasmtime#7905, `host` header in incoming requests is not available to guests Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
added a commit
to wasmCloud/wasmCloud
that referenced
this pull request
Mar 25, 2024
Since bytecodealliance/wasmtime#7905, `host` header in incoming requests is not available to guests Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the host header is required for correctness, don't allow the guest to manipulate it directly, instead allowing them to set it via the authority field on a request.