winch: Optimize calls #7927
Merged
winch: Optimize calls #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulecabrera
commented
Feb 13, 2024
saulecabrera
force-pushed
the
some-optimizations
branch
2 times, most recently
from
00477ff
to
f3421b6
Compare
This commit introduces several optimizations to speed up the compilation of function calls: * Keep track of previously resolved function signatures for local or imported callees to avoid computing the `ABISig` on every function call. * Keep track of previously resolved type signatures for indirect calls to avoid computing the `ABISig` on every function call. * Refactor `CallKnown` and `CallUnknown` instructions to make the `BoxCallInfo` field in the struct optional. Prior to this change, from Winch's perspective each call lowering involved a heap allocation, using the default values for `BoxCallInfo`, which in the end are not used by Winch. * Switch Winch's internal `Stack` to use a `SmallVec` rather than a `Vec`. Many of the operations involving builtin function calls require inserting elements at arbitrary offsets in the stack and using a `SmallVec` makes this process more efficient. With the changes mentioned above, I observed ~30% improvement in compilation times for modules that are call-heavy.
saulecabrera
force-pushed
the
some-optimizations
branch
from
f3421b6
to
b61042f
Compare
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @cfallin, @fitzgen, @saulecabrera
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several optimizations to speed up the compilation of function calls:
ABISigon every function call.ABISigon every function call.CallKnownandCallUnknowninstructions to make theBoxCallInfofield in the struct optional. Prior to this change, from Winch's perspective each call lowering involved a heap allocation, using the default values forBoxCallInfo, which in the end are not used by Winch.Stackto use aSmallVecrather than aVec. Many of the operations involving builtin function calls require inserting elements at arbitrary offsets in the stack and using aSmallVecmakes this process more efficient.With the changes mentioned above, I observed ~30% improvement in compilation times for modules that are call-heavy.