Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return EINVAL in poll_oneoff with no events. #838

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Return EINVAL in poll_oneoff with no events. #838

merged 2 commits into from
Jan 17, 2020

Conversation

marmistrz
Copy link
Collaborator

We adhere to WebAssembly/WASI#193.

kubkon
kubkon approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@kubkon kubkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

crates/wasi-common/src/hostcalls_impl/misc.rs Outdated Show resolved Hide resolved
@marmistrz marmistrz mentioned this pull request Jan 17, 2020
Merged
@sunfishcode sunfishcode merged commit 815576e into bytecodealliance:master Jan 17, 2020
@sunfishcode
Copy link
Member

Looks good to me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhuene peterhuene peterhuene approved these changes

@kubkon kubkon kubkon approved these changes

@sunfishcode sunfishcode Awaiting requested review from sunfishcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marmistrz @sunfishcode @peterhuene @kubkon