Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winch(aarch64): abs, ceil, floor, nearest, trunc, neg, sqrt #8425

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Apr 21, 2024

Adds a few more float instructions abs, neg, sqrt and all roundings (ceil, floor, nearest, trunc).

I skipped copysign for now, as it is less trivial and we probably want to port the same logic from cranelift :p

Temporarily submitting as draft because I want to double-check the test cases.

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@github-actions github-actions bot added the winch Winch issues or pull requests label Apr 21, 2024
Copy link

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general direction looks good to me, thanks! I'll give it a more in depth review once it's marked as ready.

@evacchi evacchi marked this pull request as ready for review April 26, 2024 08:41
@evacchi evacchi requested review from a team as code owners April 26, 2024 08:41
@evacchi evacchi requested review from abrown and alexcrichton and removed request for a team April 26, 2024 08:41
@evacchi
Copy link
Contributor Author

evacchi commented Apr 26, 2024

I think it should be good to go

@alexcrichton alexcrichton requested review from saulecabrera and removed request for abrown and alexcrichton April 26, 2024 12:03
Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@saulecabrera saulecabrera added this pull request to the merge queue Apr 26, 2024
Merged via the queue into bytecodealliance:main with commit a4a4c94 Apr 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
winch Winch issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants