cranelift(aarch64): Add single precision fmov #8453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a follow up to https://github.com/bytecodealliance/wasmtime/pull/8365/files#r1565962730, to enable emission of 32-bit fmov from Winch. I opted to introduce a new instruction over refactoring the existing `FpuMov64` to be more generic to keep things simple, but I'm definitely open to exploring a refactoring if that's preferred. Encoding reference: https://developer.arm.com/documentation/ddi0602/2024-03/SIMD-FP-Instructions/FMOV--register---Floating-point-Move-register-without-conversion-?lang=en
saulecabrera
requested review from
elliottt and
cfallin
and removed request for
a team
github-actions
bot
added
cranelift
saulecabrera
added a commit
to saulecabrera/wasmtime
that referenced
this pull request
Apr 24, 2024
This commit is a follow-up to bytecodealliance#8365. In bytecodealliance#8453 single precision fmov was introduced in Cranelift, so now we can make use that instruction in Winch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a follow up to https://github.com/bytecodealliance/wasmtime/pull/8365/files#r1565962730, to enable emission of 32-bit fmov from Winch.
I opted to introduce a new instruction over refactoring the existing
FpuMov64to be more generic to keep things simple, but I'm definitely open to exploring a refactoring if that's preferred.Encoding reference: https://developer.arm.com/documentation/ddi0602/2024-03/SIMD-FP-Instructions/FMOV--register---Floating-point-Move-register-without-conversion-?lang=en