Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: Pass source location through directly #8471

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

jameysharp
Copy link
Contributor

Stashing the source location in a side location is unnecessary: we already have it where we need it.

Stashing the source location in a side location is unnecessary: we
already have it where we need it.
@jameysharp jameysharp requested a review from a team as a code owner April 25, 2024 03:48
@jameysharp jameysharp requested review from cfallin and removed request for a team April 25, 2024 03:48
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. labels Apr 25, 2024
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for missing this one earlier!

@cfallin cfallin added this pull request to the merge queue Apr 26, 2024
Merged via the queue into bytecodealliance:main with commit 3e87883 Apr 26, 2024
21 checks passed
@jameysharp jameysharp deleted the srclocs branch April 26, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants